Skip to content

FQM-308/309/319: Add tests for unrecognized elements#85

Merged
karlnaden merged 21 commits into
support-v2.2.0from
fqm-319-unrecognized-hooks-elements
May 21, 2026
Merged

FQM-308/309/319: Add tests for unrecognized elements#85
karlnaden merged 21 commits into
support-v2.2.0from
fqm-319-unrecognized-hooks-elements

Conversation

@Jammjammjamm
Copy link
Copy Markdown
Contributor

Summary

This branch adds tests for three very similar requirements: that servers ignore unrecognized context, configuration, and CDS Hooks fields. They are each tested by taking a request which resulted in a successful Coverage Information response and repeating it after adding a field with a random key to the appropriate location.

Testing Guidance

These tests should pass when run against the client suite.

Anticipated Provider-side Test Impact

The unknown context and CDS Hooks fields both cause errors in the client side hook request logical model conformance tests when run against the server suite.

Screenshot 2026-05-19 at 8 11 55 AM

@Jammjammjamm Jammjammjamm requested review from arscan and tstrass May 19, 2026 12:12
@Jammjammjamm Jammjammjamm self-assigned this May 19, 2026
@arscan
Copy link
Copy Markdown
Contributor

arscan commented May 19, 2026

Just wanted to note that the maintainers of the provider-side tests are aware of change in behavior of the client simulation within these tests, and know to expect these new failures when running the provider tests against this suite.

@arscan arscan marked this pull request as ready for review May 20, 2026 15:56
@arscan arscan requested a review from karlnaden May 20, 2026 15:56
@arscan
Copy link
Copy Markdown
Contributor

arscan commented May 20, 2026

FYI @karlnaden . This PR should exhibit the change in behavior of the client-side demo as we discussed and noted in the PR description.

Copy link
Copy Markdown
Contributor

@karlnaden karlnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include an update as a part of this PR to the documentation on running the v2.2.1 client vs server suites noting that the server suite submits known-bad requests and so to expect errors on certain tests for certain requests, which we should be able to list based on what we know of the presets and the server behavior. I know you are waiting to do most documentation updates until next week, but I think this documentation update is needed at the same time this is merged to support our review of the client suite which is happening later this week.

@Jammjammjamm
Copy link
Copy Markdown
Contributor Author

@karlnaden I updated the wiki with information about the expected failures.

@Jammjammjamm Jammjammjamm requested a review from karlnaden May 21, 2026 12:25
@karlnaden
Copy link
Copy Markdown
Contributor

@karlnaden I updated the wiki with information about the expected failures.

I don't see them in the repo yet - can you confirm you pushed them up?

@Jammjammjamm
Copy link
Copy Markdown
Contributor Author

I don't see them in the repo yet - can you confirm you pushed them up?

Sorry, I forgot that the wiki is generated from the repo contents.

Comment thread docs/Running-Suites-Against-Each-Other.md Outdated
@Jammjammjamm Jammjammjamm requested a review from karlnaden May 21, 2026 13:40
@karlnaden karlnaden merged commit dc0be43 into support-v2.2.0 May 21, 2026
@karlnaden karlnaden mentioned this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants