FQM-323: Verify server prefetch support#87
Draft
Jammjammjamm wants to merge 7 commits into
Draft
Conversation
Contributor
|
Is it valid for an instance of a server to not use prefetch in any service because for some reason it just doesn't need them in that case? In which case, I wouldn't call these invalid as implied in the group title "Discovery response contains valid services". I would probably move this out to another simple test that is just "Server demonstrates ability to request the CDS Client perform prefetch queries' (language taken from https://cds-hooks.hl7.org/2026Jan/en/index.html#response). And then in the description note that the tests required demonstration of at least one prefetch query as evidence that it is capable of using prefetch. |
arscan
reviewed
May 20, 2026
tstrass
requested changes
May 20, 2026
Co-authored-by: Rob Scanlon <[email protected]>
Co-authored-by: Tom Strassner <[email protected]>
3f0d277 to
cd10232
Compare
tstrass
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds a check that at least one service advertises prefetch.
Testing Guidance
Test passes against the client suite. Failure is demonstrated in the unit tests.
Anticipated Provider-side Test Impact
None