Skip to content

Remove tgz files from gem package#119

Merged
karlnaden merged 1 commit into
inferno-framework:masterfrom
jlduran:remove-tar-artifacts
May 5, 2026
Merged

Remove tgz files from gem package#119
karlnaden merged 1 commit into
inferno-framework:masterfrom
jlduran:remove-tar-artifacts

Conversation

@jlduran
Copy link
Copy Markdown
Contributor

@jlduran jlduran commented Oct 15, 2024

There is a considerable file size increase for 5.0.0:

5.0.0 - October 14, 2024 (36.7 MB)
4.3.0 - May 30, 2024 (7.51 MB)

Mainly due to the inclusion of compressed artifacts:

Avoid it by excluding these files from the final gem package.

Comment thread fhir_models.gemspec Outdated
@jlduran jlduran force-pushed the remove-tar-artifacts branch from cafd029 to 165e8ac Compare May 4, 2026 17:58
@jlduran jlduran requested a review from karlnaden May 4, 2026 19:28
Copy link
Copy Markdown
Contributor

@karlnaden karlnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small last cleanup, then will get merged in and released - thanks

Comment thread fhir_models.gemspec Outdated
The directory lib/fhir_models/igs contains core.tgz files, which
increase the gem size considerably and are not required for normal
operation.  Remove the entire igs directory.
@jlduran jlduran force-pushed the remove-tar-artifacts branch from 165e8ac to a03ae81 Compare May 5, 2026 16:14
@jlduran jlduran requested a review from karlnaden May 5, 2026 16:14
@jlduran
Copy link
Copy Markdown
Contributor Author

jlduran commented May 5, 2026

Thank you @karlnaden. I've applied your suggestions and submitted a few additional PRs. I'd appreciate it if you could take a look at those as well when you have a moment.

@karlnaden karlnaden merged commit 4f38331 into inferno-framework:master May 5, 2026
2 checks passed
@jlduran jlduran deleted the remove-tar-artifacts branch May 5, 2026 16:24
@karlnaden
Copy link
Copy Markdown
Contributor

Thank you @karlnaden. I've applied your suggestions and submitted a few additional PRs. I'd appreciate it if you could take a look at those as well when you have a moment.

This one is merged. Will try to review the additional PRs later this week and get a gem out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants