Skip to content

ID-95: Update Validator-Wrapper container generation#772

Draft
karlnaden wants to merge 1 commit into
mainfrom
id95-update-validator-version-and-java
Draft

ID-95: Update Validator-Wrapper container generation#772
karlnaden wants to merge 1 commit into
mainfrom
id95-update-validator-version-and-java

Conversation

@karlnaden
Copy link
Copy Markdown
Contributor

TODO: need to add a snomed CT version to at least US core tests - add to the validator context: snomedCT: "731000124108",

Summary

This PR updates the Docker file used to build Inferno-specific images for the HL7 fhir-validator-wrapper project to match changes made in that project in recent versions

  1. Require Java 17.
  2. Use a different name for the downloadable jar file.

Additionally, the lines to pull MITRE certificates were commented out as the project no longer is run by that team and we don't have access to the scripts any longer.

Notes:

  • A nice bonus of this version update appears to be a significant improvement in package load times. Complex IGs like DTR and CRD were very slow in the latest Inferno version released.
  • This fixes some specific issues observed within the DTR test kit, both in 2.0.1 profiles and 2.2.0 profiles.

Testing Guidance

Since we are testing in QA this week, a 1.0.73 image version was generated and pushed, but not tagged with latest for use in testing. The latest tag and g10 updates will be added once this is merged.

  1. Update the hl7_validator_service entry in the docker-compose.background.yml file to use image: infernocommunity/inferno-resource-validator:1.0.73
  2. Update the gemfile and demo dev suite to import the g10 test kit.
  3. TODO: finish these instructions

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.63%. Comparing base (0504971) to head (014ad26).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
+ Coverage   84.61%   84.63%   +0.01%     
==========================================
  Files         296      296              
  Lines       13729    13745      +16     
  Branches     1887     1895       +8     
==========================================
+ Hits        11617    11633      +16     
  Misses       2104     2104              
  Partials        8        8              
Flag Coverage Δ
backend 92.39% <ø> (+<0.01%) ⬆️
frontend 79.39% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant