ID-82: fix suite-level unmatched requirements bug#779
Open
karlnaden wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 84.78% 84.79% +0.01%
==========================================
Files 297 297
Lines 13969 13969
Branches 1955 1955
==========================================
+ Hits 11843 11845 +2
+ Misses 2118 2116 -2
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the requirement coverage checker contained a bug where when addressing requirements linked to a test for which the requirement set it not linked to the suite would cause an error. Now, that error is resolved by using the same logic that handles suite-level requirements elsewhere .
Testing Guidance
Found and verified when updating CRD test kit requirements. To confirm:
bundle exec inferno consoleto access the Inferno console.Inferno::CLI::RequirementsCoverageChecker.new(:ig_requirements).run. You will see in the table written to the console, a row forshort_id"suite" (the suite has a requirement at the suite level in a requirement set not linked to the suite). Previously, no table would have been returned. (NOTE: the command will still end in an error due to no output directory, which is expected in inferno-core).