ID-45: Improve session compare csv file#780
Open
karlnaden wants to merge 1 commit into
Open
Conversation
… only returning different messages
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
=======================================
Coverage 84.77% 84.78%
=======================================
Files 297 297
Lines 13968 13969 +1
Branches 1955 1955
=======================================
+ Hits 11842 11843 +1
Misses 2118 2118
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the expected and actual messages columns of the comparison csv generated by the session compare CLI when the compared session does not match the expected results did not always contain helpful details and often cells were too long. Specifically, extra messages would throw off the comparison and data in a single cell could go over the csv line limit. Now, three enhancements make the output more usable:
Testing Guidance
TODO