Skip to content

Remove references to private validator functions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljtucker merged 3 commits into from
Mar 5, 2026
Merged

Remove references to private validator functions #44

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509134b
Remove references to private validator functions
ljtucker Mar 5, 2026
acafbaf
Use DSL reference
ljtucker Mar 5, 2026
b1ec296
Update lib/ipa_test_kit/reference_resolution_test.rb
ljtucker Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions lib/ipa_test_kit/reference_resolution_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,19 +162,16 @@ def validate_reference_resolution(resource, reference, target_profile)
def resource_is_valid_with_target_profile?(resource, target_profile)
return true if target_profile.blank?

# Only need to know if the resource is valid.
# Calling resource_is_valid? causes validation errors to be logged.
validator = find_validator(:default)
validator_response = validator.validate(resource, target_profile)
outcome = validator.operation_outcome_from_hl7_wrapped_response(validator_response)

message_hashes = outcome.issue&.map { |issue| validator.message_hash_from_issue(issue, resource) } || []

message_hashes.concat(validator.additional_validation_messages(resource, target_profile))

validator.filter_messages(message_hashes)

message_hashes.none? { |message_hash| message_hash[:type] == 'error' }
# Use the validator's resource_is_valid? method with add_messages_to_runnable: false
# to validate silently without adding messages to the test output
validator.resource_is_valid?(
resource,
target_profile,
self,
add_messages_to_runnable: false
)
end
end
end