gem dependency updates and addressing vulnerabilities + non-FHIR:reference filter added#290
Closed
FlexonyoPizza wants to merge 1 commit into
Closed
gem dependency updates and addressing vulnerabilities + non-FHIR:reference filter added#290FlexonyoPizza wants to merge 1 commit into
FlexonyoPizza wants to merge 1 commit into
Conversation
karlnaden
requested changes
May 11, 2026
|
|
||
| resolve_one_reference = resources.any? do |resource| | ||
| value_found = resolve_path(resource, path) | ||
| value_found = resolve_path(resource, path).select { |v| v.is_a?(FHIR::Reference) } |
Contributor
There was a problem hiding this comment.
This looks like it could be the right fix. However, we need at least a spec test case in the reference_test_spec.rb and ideally an example execution in the UI that demonstrates that it is resolved. Looks like I did make the same change in a branch I'm working on here, but haven't gotten around to a spec test yet. So I think it is right and should be relatively easy to get a test that proves it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filler gem path to inferno-core, tls-test-kit, and smart-app-test-kit in order to bundle install and update gemlock locally. Will remove those gem path and reference the actual inferno-core, tls-test-kit, and smart-app-test-kit versions once those gems are released.
Added a filter in lib/reference_resolution_test.rb that filters out non-FHIR:reference variants passed to
"def unresolved_references(resources = [])";
Some suite tests (in particular medication[x] tests) in the g10 test kit wouldn't pass because 'CodeableConcept' variants were being passed to that function in US-core that only accepts FHIR:reference variants.