Gem updates and FHIR:reference guard rail that filters out codeableCo…#291
Merged
Conversation
…ncept variants being passed
karlnaden
requested changes
May 13, 2026
|
|
||
| BUNDLED WITH | ||
| 2.5.22 | ||
| 4.0.7 |
Contributor
There was a problem hiding this comment.
I don't think we want to update the bundler version. Can you:
- revert Gemfile.lock to its state before your pr
- regenerate it using
bundle _2.5.22_ update
karlnaden
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gem Updates in gemspec:
lib/us_core_test_kit/reference_resolution_test.rb line 87:
spec/us_core/reference_test_spec.rb — two new test groups added:
Tests the guard rail added at line 87 of reference_resolution_test.rb:
value_found = resolve_path(resource, path).select { |v| v.is_a?(FHIR::Reference) }
Verifies that when resolve_path returns a FHIR::CodeableConcept for a choice-type path (e.g. medication[x]), it is filtered out before any .reference call is made — preventing a NoMethodError crash. Also confirms the path is not counted as unresolved, since no actual reference was found.
Uses the real USCoreV311::MedicationRequestReferenceResolutionTest class against a stubbed FHIR server returning a MedicationRequest with medicationCodeableConcept. Confirms two things: