Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Other accepted value #15

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Add Other accepted value #15

merged 2 commits into from
Feb 5, 2024

Conversation

paulg66
Copy link
Contributor

@paulg66 paulg66 commented Jan 31, 2024

Add other as an accepted value in bi tests so support uncategorized dbt tests.

resolves #14

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Add 'Other' as an accepted value on two dbt tests for models in the BI section so these tests will pass when using alternative tests that don't have a kpi_category.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • SQL Server
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

Add other as an accepted value in bi tests so support uncategorized dbt tests.
@paulg66
Copy link
Contributor Author

paulg66 commented Jan 31, 2024

cc @il-dat - for your review when you have a moment.

@il-dat
Copy link
Collaborator

il-dat commented Feb 1, 2024

Hey @paulg66 LGTM thank you!

Just a minor comment, in order to support 'Other', do you think we should remove the filter in bi_dq_metrics.sql?

Remove where condition for dq_dimension to include 'Other' kpi_category in final result
@paulg66
Copy link
Contributor Author

paulg66 commented Feb 1, 2024

Hey @paulg66 LGTM thank you!

Just a minor comment, in order to support 'Other', do you think we should remove the filter in bi_dq_metrics.sql?

@il-dat ya that's a good call, the PR has be updated to reflect this change.

@il-dat il-dat merged commit c94cf7c into infinitelambda:main Feb 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Accepted Values test failing when kpi_category is not one of the 6 main categories
2 participants