Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/37 fix skip ephemeral models #38

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

il-ngocanh
Copy link
Collaborator

resolves #37

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@il-ngocanh il-ngocanh requested a review from il-dat October 18, 2024 02:16
Copy link
Collaborator

@il-dat il-dat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @il-ngocanh

PS: CI is being broken, so no worries, I confirmed it locally ✅

@il-dat il-dat merged commit 94d96fa into main Oct 21, 2024
0 of 2 checks passed
@il-dat il-dat deleted the bugfix/37-fix-skip-ephemeral-models branch October 21, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default behaviour of dq_tools.store_test_results to skip ephemeral models
2 participants