Skip to content

Feature/auto light theme #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2025
Merged

Feature/auto light theme #1547

merged 5 commits into from
Mar 13, 2025

Conversation

arkthur
Copy link
Contributor

@arkthur arkthur commented Mar 10, 2025

Please verify the following:

  • yarn build-and-test:local passes
  • I have added tests for any new features, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

Added a light theme and logic that switches themes according to system preferences.

@arkthur arkthur mentioned this pull request Mar 10, 2025
Open
coolsoftwaretyler
coolsoftwaretyler requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arkthur - thanks for the PR! I had a couple small points of feedback for you, but other than that I see things working quite well.

Screen.Recording.2025-03-10.at.7.45.34.PM.mov

@arkthur
Copy link
Contributor Author

arkthur commented Mar 11, 2025

Now I added a custom hook so the listener can be properly removed on unmount and the logic is less repetitive, avoiding redundancy.

@arkthur
Copy link
Contributor Author

arkthur commented Mar 12, 2025

Just pushed a fix for the unit tests, which includes some needed changes to the hook

coolsoftwaretyler
coolsoftwaretyler approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for making those changes. I'll grab someone else from IR to take a look as well and then hopefully merge.

Thanks!

frankcalise
frankcalise reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

One last check though, @arkthur could you include a screenshot of the <TreeView /> since there were changes there. Or a video of the timeline and expanding some JSON response for example.

Thanks!

@arkthur
Copy link
Contributor Author

arkthur commented Mar 12, 2025

@frankcalise as per requested
Screenshot 2025-03-12 at 12 37 05

@arkthur
Copy link
Contributor Author

arkthur commented Mar 12, 2025

One last thing, though.

Screen.Recording.2025-03-12.at.13.00.08.mov

Looking into it right now.

@arkthur
Copy link
Contributor Author

arkthur commented Mar 12, 2025

@frankcalise @coolsoftwaretyler Now we're talking!

Screen.Recording.2025-03-12.at.13.26.39.mov

frankcalise
frankcalise approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for the extra thorough checks

@coolsoftwaretyler coolsoftwaretyler merged commit 6477628 into infinitered:master Mar 13, 2025
3 checks passed
@arkthur arkthur deleted the feature/auto-light-theme branch March 13, 2025 13:10
camilossantos2809 pushed a commit to camilossantos2809/reactotron that referenced this pull request Mar 14, 2025
@arkthur @camilossantos2809
feat(reactotron-app): add auto light/dark mode switching (infinitered…
f64ea90 
…#1547 by @arkthur)

- [x] `yarn build-and-test:local` passes
- [x] I have added tests for any new features, if relevant
- [x] `README.md` (or relevant documentation) has been updated with your
changes

Added a light theme and logic that switches themes according to system
preferences.
camilossantos2809 pushed a commit to camilossantos2809/reactotron that referenced this pull request Mar 14, 2025
@arkthur @camilossantos2809
feat(reactotron-app): add auto light/dark mode switching (infinitered…
1f1d682 
…#1547 by @arkthur)

- [x] `yarn build-and-test:local` passes
- [x] I have added tests for any new features, if relevant
- [x] `README.md` (or relevant documentation) has been updated with your
changes

Added a light theme and logic that switches themes according to system
preferences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcalise frankcalise frankcalise approved these changes

@coolsoftwaretyler coolsoftwaretyler coolsoftwaretyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkthur @frankcalise @coolsoftwaretyler