Skip to content

Housekeeping: Update dependencies - Nov 25'#15

Open
KCeh wants to merge 3 commits into
mainfrom
housekeeping/update-dependencies-11-25
Open

Housekeeping: Update dependencies - Nov 25'#15
KCeh wants to merge 3 commits into
mainfrom
housekeeping/update-dependencies-11-25

Conversation

@KCeh

@KCeh KCeh commented Nov 28, 2025

Copy link
Copy Markdown
Collaborator

Summary

Just housekeeping, updating project and dependencies

Changes

  • gitignore update
  • dependecies update

Type

  • Feature: This pull request introduces a new feature.
  • Bug fix: This pull request fixes a bug.
  • Refactor: This pull request refactors existing code.
  • Documentation: This pull request updates documentation.
  • Other: This pull request makes other changes.

Additional information

  • This pull request introduces a breaking change.

Description

Checklist

  • I have performed a self-review of my own code.
  • I have tested my changes, including edge cases.
  • I have added necessary tests for the changes introduced (if applicable).
  • I have updated the documentation to reflect my changes (if applicable).

Additional notes

@KCeh KCeh requested a review from Copilot November 28, 2025 07:48
@KCeh KCeh self-assigned this Nov 28, 2025
@KCeh KCeh added the enhancement New feature or request label Nov 28, 2025
@KCeh KCeh changed the title Housekeeping: Update dependencies- Nov 25' Housekeeping: Update dependencies - Nov 25' Nov 28, 2025
@KCeh KCeh requested a review from AsimRibo November 28, 2025 07:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@AsimRibo AsimRibo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image
Lookin good.

Comment thread .gitignore Outdated
.idea/modules.xml
# Comment next line if keeping position of elements in Navigation Editor is relevant for you
.idea/navEditor.xml
.idea/*

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have specific .idea patterns, what is the idea behind wildcard? Are specific idea rules even needed then?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added it on top of already existing ignore rules, specific rules are not needed then, but I don't think it is a big problem

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems?page=4

Ignoring the entire .idea folder is a bit of a nuclear option and not recommended by Jetbrains

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I guess then we will improve the rules

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider doing a bit of a hybrid approach as outlined in the article:
https://blog.sebastiano.dev/anatomy-of-a-gitignore/

Since I noticed some plugins like to put stuff in .idea that should not be shared, so I do think it's more practical to ignore by default, but intentionally un-ignore some stuff that should be shared.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KCeh KCeh Nov 28, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this config?

related IDE config:

*.iml
*.ipr
*.iws
/.idea/*

# Exclude non-user-specific stuff
!.idea/.name
!.idea/codeInsightSettings.xml
!.idea/codeStyles/
!.idea/copyright/
!.idea/dataSources.xml
!.idea/detekt.xml
!.idea/encodings.xml
!.idea/externalDependencies.xml
!.idea/file.template.settings.xml
!.idea/fileTemplates/
!.idea/icon.svg
!.idea/inspectionProfiles/
!.idea/runConfigurations/
!.idea/scopes/
!.idea/vcs.xml

These are files I am getting as diff before nuclear option of ignoring whole .idea folder:

Screenshot 2025-11-28 at 13 30 36

Looking at what they do, it might be useful to keep (but nothing super important):

.name
runConfigurations.xml
kotlinc.xml
AndroidProjectSystem.xml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of those exclusions might be outdated, such as the runConfiguration folder, which I don't see nowadays and instead only see the .xml file 🤔 same with detekt.xml, we keep detekt rules elsewhere. But I do agree with your list of exclusions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants