Update supported ruby versions#63
Merged
Merged
Conversation
lovro-bikic
reviewed
Dec 12, 2025
| SimpleCov.start | ||
|
|
||
| require 'minitest/autorun' | ||
| require 'logger' |
Member
There was a problem hiding this comment.
Do we still need this change?
Contributor
Author
There was a problem hiding this comment.
yeah, I couldn't run the tests locally without it
Member
There was a problem hiding this comment.
Hmm, tests pass locally for me, even with the String class change:
Does this fail on a specific Ruby version?
Contributor
Author
There was a problem hiding this comment.
It was an issue with the older version of activesupport for me locally. Removing the Gemfile.lock and running bundle install again fixed the issue and tests pass without this logger requirement on all supported ruby versions.
lovro-bikic
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done as part of #1224
Aim
Drop support for ruby 2.6 and 2.7
Add support for ruby 3.2, 3.3 and 3.4
Solution
Updated test.yml
Update required ruby version in gemspec