Return stored enumeration instances as-is from attribute getters#67
Merged
lovro-bikic merged 1 commit intoJun 29, 2026
Merged
Conversation
lovro-bikic
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 3.0
Enumerations::Baseinherits fromString. Indefine_attributes_gettersthewhen String, Symbolbranch now also matches an enum instance stored as another enum's attribute (it is aStringnow), routing it throughtranslate_attributeand returning a plainStringinstead of the enum instance.So an attribute that stores another enumeration:
Added a
when Enumerations::Basebranch before theString/Symbolbranch so the stored instance is returned as-is. Order matters sinceBase < String. Also added a regression test.