Skip to content

Conversation

djordjelacmanovic
Copy link
Contributor

@djordjelacmanovic djordjelacmanovic commented Sep 14, 2025

Relax json_schemer version so gems (e.g. activerecord_json_validator) that depend on it can be updated. Needed for Rails 8 updates.

After merge and release of new version update https://github.com/infinum/rails-infinum-guess_who/pull/353 to remove the dependency on GitHub ref.

Related issue: #1196

@djordjelacmanovic djordjelacmanovic marked this pull request as ready for review September 25, 2025 20:52
@djordjelacmanovic djordjelacmanovic requested review from vr4b4c and a team September 25, 2025 20:52
Copy link
Member

@vr4b4c vr4b4c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague recollection about JSON schema resolution issues from the past. Are you sure request specs on the existing projects are green with this change (one example is enough)?

@djordjelacmanovic
Copy link
Contributor Author

I have a vague recollection about JSON schema resolution issues from the past. Are you sure request specs on the existing projects are green with this change (one example is enough)?

Yes, see https://github.com/infinum/rails-infinum-guess_who/pull/353, there are multiple match_response_schema uses in tests and that PR is on json_schemer (2.4.0) with

gem 'infinum_json_api_setup', github: 'infinum/infinum-json-api-setup', ref: '346fa0dc203a413c43ea5d9b4139cf3cd874301c'

@djordjelacmanovic djordjelacmanovic force-pushed the fix/relax-json-schemer-version branch 3 times, most recently from 8483e6d to eb01b80 Compare October 8, 2025 07:26
@djordjelacmanovic
Copy link
Contributor Author

djordjelacmanovic commented Oct 8, 2025

Also pulled in ostruct as explicit dependency in eb01b80, required for Ruby 3.4+ support (deprecated and not loaded by default in Ruby 3.4, removed in 3.5)

OpenStruct usages InfinumJsonApiSetup::Rspec::Helpers::ResponseHelper were not covered by specs so we didn't have a failing test case. Will need to add those in too.

@djordjelacmanovic djordjelacmanovic changed the title Relax json_schemer dependency Relax json_schemer dependency, add ostruct explicitly Oct 8, 2025
@djordjelacmanovic djordjelacmanovic force-pushed the fix/relax-json-schemer-version branch from 403f251 to ddc4aa0 Compare October 8, 2025 09:08
@djordjelacmanovic djordjelacmanovic merged commit 5004a45 into master Oct 8, 2025
6 checks passed
@djordjelacmanovic djordjelacmanovic deleted the fix/relax-json-schemer-version branch October 8, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants