-
Notifications
You must be signed in to change notification settings - Fork 1
add support for multiple preference types #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZvonimirMedak
wants to merge
19
commits into
master
Choose a base branch
from
feature/support-multiple-preference-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple-preference-types
…rash-detection-tool
…pport-multiple-preference-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on #32 I have added support for multiple preference types in SwiftUI
Changes
Type
Additional information
Description
This PR adds a PreferenceItem protocol which will be used on the Preferences screen.
Added the support for Text, Int, Float, Double, and picker (CustomStringConvertible + RawRepresentable).
There are also validators which can be used with those items.
The UI has also been updated to have a description label below the item which will show the description or the last error message from the Validator
Checklist
Additional notes
The ToggleToolItem kept the same name due to it already existing in Sentinel, maybe we can create a type alias which would be PreferenceBoolItem, and then we could use both without creating a breaking change.