feat(iceberg): omit deleted files within fast-append #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdockerty
force-pushed
the
feat/delete-files
branch
from
a7a9dcf to
aff888f
Compare
jdockerty
force-pushed
the
feat/delete-files
branch
from
aff888f to
20cb183
Compare
jdockerty
changed the title
To avoid hitting the todo/unimplemented panic, these match arms must be filled in. Whether it actually matters what is here remains to be seen.
This removes the iter.position hack with front-loaded computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch off
0.5.1oficeberg-rustwhich adds some changes to omit deleted files within a fast append action.It is not currently possible to perform "file-level" deletes via the upstream
iceberg-rustimplementation.This is heavily inspired by something similar being done by the folks at RisingWave, but has been adapted for an internal use case for an interaction with our iceberg exporter and the IOx compactor.