Skip to content

chore: delete unnecessary inheritance of FlowableBufferTimedFlushable #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: delete unnecessary inheritance of FlowableBufferTimedFlushable #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b88de8
refactor(flowable): remove unnecessary inheritance from FlowableBuffe…
OrezzerO Dec 25, 2024
327b860
refactor(flowable): remove unnecessary inheritance from FlowableBuffe…
OrezzerO Jan 9, 2025
ad83f31
docs: Update CHANGELOG.md
bednar Jan 9, 2025
50589b1
docs: Update CHANGELOG.md
bednar Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

⚠️ Important Notice: Starting from this release, we won’t be listing every dependency change in our changelog. This helps us maintain the project faster and focus on important features for our InfluxDB client.

### Bug Fixes

1. [#794](https://github.com/influxdata/influxdb-client-java/issues/794): Delete unnecessary inheritance of `FlowableBufferTimedFlushable`.

## 7.2.0 [2024-08-12]

### Features
Expand Down
8 changes: 1 addition & 7 deletions client/src/main/java/com/influxdb/client/internal/flowable/FlowableBufferTimedFlushable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
* @param <U> the output value type
* @see FlowableBufferTimed
*/
public final class FlowableBufferTimedFlushable<T, U extends List<? super T>> extends Flowable<U>
implements FlowableTransformer<T, U> {
public final class FlowableBufferTimedFlushable<T, U extends List<? super T>> extends Flowable<U> {

final Publisher<T> source;
final Publisher<Boolean> flusher;
Expand Down Expand Up @@ -67,11 +66,6 @@ public FlowableBufferTimedFlushable(Publisher<T> source,
this.restartTimerOnMaxSize = true;
}

@Override
public @NonNull Publisher<U> apply(@NonNull final Flowable<T> upstream) {
return new FlowableBufferTimedFlushable<>(upstream, flusher, timeskip, unit, maxSize, scheduler, bufferSupplier);
}

@Override
protected void subscribeActual(@NonNull final Subscriber<? super U> subscriber) {
Scheduler.Worker w = scheduler.createWorker();
Expand Down
Loading