Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bucket pagination #658

Merged
merged 5 commits into from
May 28, 2024

Conversation

mbenabda
Copy link
Contributor

@mbenabda mbenabda commented May 24, 2024

Proposed Changes

Simliar to #616 for buckets:
Add buckets_api.find_buckets_iter to make usage of buckets pagination simpler

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@mbenabda mbenabda force-pushed the pr/add_paging_to_buckets_api branch 3 times, most recently from 8e90900 to f3f0914 Compare May 24, 2024 13:10
@mbenabda mbenabda force-pushed the pr/add_paging_to_buckets_api branch from f3f0914 to 7bf9322 Compare May 24, 2024 21:15
@mbenabda mbenabda marked this pull request as ready for review May 25, 2024 16:51
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbenabda, thank you very much for your PR. Before we can proceed with merging, there are a few requirements that need to be met:

Co-authored-by: Jakub Bednář <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.43%. Comparing base (73849e7) to head (15a7880).
Report is 9 commits behind head on master.

Files Patch % Lines
influxdb_client/client/_pages.py 95.12% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   90.40%   90.43%   +0.02%     
==========================================
  Files          39       40       +1     
  Lines        3513     3524      +11     
==========================================
+ Hits         3176     3187      +11     
  Misses        337      337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍

LGTM 🚀

@bednar bednar added this to the 1.44.0 milestone May 28, 2024
@bednar bednar merged commit 6798be4 into influxdata:master May 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants