fix: specify env.ts more specifically for newer node versions #7001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
philjb
commented
Jan 29, 2025
philjb
commented
- cherry-pick of fix: specify env.ts more specifically for newer node versions #7000
* cherry-pick of #7000 Co-authored-by: Bill OConnell <[email protected]>
wdoconnell
approved these changes
Jan 29, 2025
|
@philjb This looks good to go. The CI failure is being handled internally with a fix from @solomonope. I'll leave the details out of this PR since this is a public repo. |
|
@wdoconnell mentioned internally that ci was fixed but getting it pulled for this pr is not required: pr #7000 merged so i'm merging this pr now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.