Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): remove notebook's unused buttons #7008

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 14, 2025

Closes #6931

Remove two unused buttons in the Notebook screen for OSS:

Before:
360171779-018c7fb3-7698-43b7-aca1-7ed4942b36de
After:
Screenshot 2025-02-14 at 10 13 26

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 14, 2025
@NguyenHoangSon96 NguyenHoangSon96 requested a review from a team as a code owner February 14, 2025 03:30
@NguyenHoangSon96 NguyenHoangSon96 linked an issue Feb 14, 2025 that may be closed by this pull request
@NguyenHoangSon96 NguyenHoangSon96 changed the title Feat/remove notebook's unused buttons feat(ui): remove notebook's unused buttons Feb 14, 2025
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source branch should be master; the OSS-2.7 branch is used for releases.

Removing the button should depend on the CLOUD property, because the source is shared between CLOUD and OSS. You can use something like:

ui/src/App.tsx

Line 146 in 5cfee32

{CLOUD ? (

@NguyenHoangSon96 NguyenHoangSon96 changed the base branch from OSS-2.7 to master February 19, 2025 01:19
@NguyenHoangSon96 NguyenHoangSon96 requested a review from a team as a code owner February 19, 2025 01:19
@NguyenHoangSon96
Copy link
Author

The source branch should be master; the OSS-2.7 branch is used for releases.

Removing the button should depend on the CLOUD property, because the source is shared between CLOUD and OSS. You can use something like:

ui/src/App.tsx

Line 146 in 5cfee32

{CLOUD ? (

Hi @bednar
I make some changes based on your request
Please check again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove buttons for notebook versions in oss
2 participants