Skip to content

[IMP] account_ux: Add branch_order to re order journal given more priority to branch journals if you are setting from a branch #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjscarafia merged 1 commit into from
Jan 7, 2026
Merged

[IMP] account_ux: Add branch_order to re order journal given more priority to branch journals if you are setting from a branch #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions account_ux/models/account_journal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

class AccountJournal(models.Model):
_inherit = "account.journal"
_order = "branch_order,sequence, type, code"

mail_template_id = fields.Many2one(
"mail.template",
Expand All @@ -26,12 +27,38 @@ class AccountJournal(models.Model):
"company's journals for their transactions.",
)
has_child_companies = fields.Boolean(compute="_compute_has_child_companies")
branch_order = fields.Integer(
compute="_compute_branch_order",
store=True,
help="Priority sequence for branches. Low number if I am a branch, high number if I am a parent",
)

@api.depends("company_id", "company_id.child_ids")
def _compute_has_child_companies(self):
for journal in self:
journal.has_child_companies = bool(journal.company_id.child_ids)

@api.depends("company_id", "company_id.child_ids", "company_id.parent_id")
def _compute_branch_order(self):
for journal in self:
# Calculate the leves of the child hierarchy
level = 0
companies_to_check = journal.company_id.child_ids
while companies_to_check:
level += 10
# Get all children of the next level
companies_to_check = companies_to_check.mapped("child_ids")

if journal.company_id.child_ids:
# If it has children, the base value is 100 plus level
journal.branch_order = 100 + level
elif journal.company_id.parent_id:
# If it's a branch (has a parent), low value
journal.branch_order = 100
else:
# If it has neither parent nor children, base value
journal.branch_order = 10

@api.onchange("shared_to_branches")
def _onchange_shared_to_branches(self):
if self.type == "sale" and self.shared_to_branches:
Expand Down