[FIX] account_ux: add aggregator to monetary fields in invoice report #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull request overview
Este PR corrige un problema agregando el parámetro aggregator="sum" a varios campos monetarios en el reporte de facturas (account.invoice.report). Esto permite que estos campos se agreguen correctamente cuando se utilizan en vistas agrupadas, pivotes o gráficos.
Cambios clave:
- Se añade
aggregator="sum"a 5 campos monetarios:price_subtotal,price_total,price_average,total_ccyprice_subtotal_currency - Se reformatea
price_subtotal_currencyen múltiples líneas para mantener consistencia de estilo
account_ux/reports/invoice_report.py
Outdated
| currency_field="current_currency_id", | ||
| string="Average Price (CC)", | ||
| help="Average Price in the company's currency where it is set", | ||
| aggregator="sum", |
There was a problem hiding this comment.
El campo price_average representa un precio promedio, no una suma de valores. Usar aggregator="sum" en un campo de precio promedio es conceptualmente incorrecto y podría dar resultados engañosos en vistas agrupadas o pivotes. Para campos de precio promedio, el agregador debería ser "avg" (average) o no especificarse si el cálculo del promedio se hace de otra manera.
Suggested change
| aggregator="sum", | |
| aggregator="avg", |
rov-adhoc
force-pushed
the
19.0-h-107565-rov
branch
from
4dd0180 to
795b482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.