[WIP] #865
Closed
[WIP] #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osition support This commit improves the exchange difference wizard to properly handle taxes and fiscal positions when creating debit/credit notes. Main changes: - Add fiscal_position field to wizard (automatic/manual selection) - Add fiscal_position_id field for manual fiscal position assignment - Implement tax proration logic in _prepare_invoice_lines_by_taxes(): * Groups invoice lines by tax combination * For Argentina: only considers VAT taxes (with l10n_ar_vat_afip_code) * Prorates exchange difference amount across tax groups based on their weight * Handles rounding differences by adjusting the last line - Refactor _prepare_debit_credit_note() to: * Accept exch_moves parameter to retrieve related invoice lines * Generate separate lines for each tax combination * Apply manual fiscal position when configured - Update wizard view to show fiscal position fields This ensures exchange difference debit/credit notes have the same tax structure as the original invoices, maintaining proper tax tracking and compliance. X-original-commit: 22f4f94
…osition When calculating tax groups for proration in the exchange difference wizard, we need to ensure that if the invoice has a fiscal position, the perceptions and other tax amounts should not be included in the subtotal used for proration. This case only applies if the user selects automatic fiscal position application in the wizard. Also, if user selects manual and not fiscal position id, the fiscal position will be cleaned from the invoice to avoid re-calculation taxes when adding the date. X-original-commit: a26a4a1
|
|
Contributor
Author
|
@jjscarafia @cav-adhoc this PR targets 19.0 and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Jan 5, 2026
…osition support This commit improves the exchange difference wizard to properly handle taxes and fiscal positions when creating debit/credit notes. Main changes: - Add fiscal_position field to wizard (automatic/manual selection) - Add fiscal_position_id field for manual fiscal position assignment - Implement tax proration logic in _prepare_invoice_lines_by_taxes(): * Groups invoice lines by tax combination * For Argentina: only considers VAT taxes (with l10n_ar_vat_afip_code) * Prorates exchange difference amount across tax groups based on their weight * Handles rounding differences by adjusting the last line - Refactor _prepare_debit_credit_note() to: * Accept exch_moves parameter to retrieve related invoice lines * Generate separate lines for each tax combination * Apply manual fiscal position when configured - Update wizard view to show fiscal position fields This ensures exchange difference debit/credit notes have the same tax structure as the original invoices, maintaining proper tax tracking and compliance. X-original-commit: 22f4f94 Part-of: #865 Signed-off-by: Camila Vives <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-Port-Of: #851