Skip to content

[IMP] academic_sale_subscription: improve message subscription logic … #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lef-adhoc wants to merge 1 commit into from
Closed

[IMP] academic_sale_subscription: improve message subscription logic … #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions academic_sale_subscription/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,12 @@ def _compute_student_ids(self):

def _post(self, soft=True):
for rec in self:
partners_invoice = rec.student_id.payment_responsible_ids if rec.student_id else self.env["res.partner"]
rec.message_subscribe(
[
payment_responsible.id
for payment_responsible in rec.partner_id | partners_invoice
if payment_responsible not in rec.sudo().message_partner_ids
]
)
if rec.student_id:
family_partners = rec.student_id.student_link_ids.mapped("partner_id")
partners_to_subscribe = rec.partner_id | family_partners
to_subscribe = partners_to_subscribe - rec.sudo().message_partner_ids
if to_subscribe:
rec.message_subscribe(partner_ids=to_subscribe.ids)
return super()._post(soft=soft)

def _compute_is_academic_sale(self):
Expand Down
13 changes: 6 additions & 7 deletions academic_sale_subscription/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,12 @@ def _prepare_invoice(self):
def create(self, vals_list):
orders = super().create(vals_list)
for order in orders.filtered("is_academic_sale"):
order.message_subscribe(
[
payment_responsible.id
for payment_responsible in order.partner_invoice_id | order.partner_invoice_ids
if payment_responsible not in order.sudo().message_partner_ids
]
)
if order.partner_id:
family_partners = order.partner_id.student_link_ids.mapped("partner_id")
partners_to_subscribe = order.partner_invoice_id | family_partners
to_subscribe = partners_to_subscribe - order.sudo().message_partner_ids
if to_subscribe:
order.message_subscribe(partner_ids=to_subscribe.ids)
return orders

def _message_get_default_recipients(self):
Expand Down