Skip to content

[FIX]product_replenishment_cost:force_company no longer used #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcadhoc wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX]product_replenishment_cost:force_company no longer used #818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions product_replenishment_cost/models/product_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
# For copyright and license notices, see __manifest__.py file in module root
# directory
##############################################################################
from odoo import models, fields, api, _
from odoo.tools import float_compare
from odoo.exceptions import ValidationError
import logging

from odoo import api, fields, models
from odoo.tools import float_compare

_logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -76,11 +77,10 @@ def _compute_supplier_data(self):
""" Lo ideal seria utilizar campo related para que segun los permisos
del usuario tome el seller_id que corresponda, pero el tema es que el
cron se corre con admin y entonces siempre va a tomar el primer seller
sin importar si estamos usando un force_company para poder definir rel
costo en distintas compañias.
sin importar la compañía actual para poder definir el costo en distintas compañías.
Basicamente usamos regla analoga a la que viene por defecto para los
sellers donde se puede ver si
no tiene cia o es cia del usuario.
sellers donde se puede ver si no tiene cia o es cia del usuario.
Usamos with_company() para cambiar el contexto de compañía (Odoo v16+).
"""
company_id = self.env.company.id
for rec in self:
Expand All @@ -101,11 +101,6 @@ def cron_update_cost_from_replenishment_cost(self, limit=None, company_ids=None,
tampoco podemos usar get_param porque justamente no se va a refrescar el valor
"""

# allow force_company for backward compatibility
force_company = self._context.get('force_company', False)
if force_company and company_ids:
raise ValidationError(_(
"The argument 'company_ids' and the key 'force_company' on the context can't be used together"))
# buscamos cual fue el ultimo registro actualziado
parameter_name = 'product_replenishment_cost.last_updated_record_id'
last_updated_param = self.env['ir.config_parameter'].sudo().search([('key', '=', parameter_name)], limit=1)
Expand All @@ -115,10 +110,8 @@ def cron_update_cost_from_replenishment_cost(self, limit=None, company_ids=None,
domain = [('id', '>', int(last_updated_param.value))]
records = self.with_context(prefetch_fields=False).search(domain, order='id asc')

# use company_ids or force_company or search for all companies
if force_company:
company_ids = [force_company]
elif not company_ids:
# use company_ids or search for all companies
if not company_ids:
company_ids = self.env['res.company'].search([]).ids

for company_id in company_ids:
Expand Down