Skip to content

[IMP]purchase_ux: Prevent cancelling done purchase orders #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcadhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[IMP]purchase_ux: Prevent cancelling done purchase orders #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions purchase_ux/models/purchase_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,12 @@ def _prepare_invoice(self):
if self.internal_notes:
result["internal_notes"] = self.internal_notes
return result

def button_cancel(self):
# Check if any of the selected purchase orders are in 'done' state
done_orders = self.filtered(lambda po: po.state == "done")
if done_orders:
raise UserError(
_("Cannot cancel purchase order(s) that are already done: %s") % ", ".join(done_orders.mapped("name"))
)
return super().button_cancel()