Skip to content

[IMP] sale_ux: Unlink inactive tax id on duplicate sale order #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fw-bot-adhoc wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[IMP] sale_ux: Unlink inactive tax id on duplicate sale order #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sale_ux/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
##############################################################################
from datetime import timedelta

from odoo import _, api, fields, models
from odoo import Command, _, api, fields, models
from odoo.exceptions import UserError, ValidationError
from odoo.tools import float_is_zero
from odoo.tools.safe_eval import safe_eval
Expand Down Expand Up @@ -263,6 +263,8 @@ def copy(self, default=None):
"" if not old_order else _("This sale order was duplicated from %s", old_order._get_html_link())
)
new_orders._message_log_batch(bodies=bodies)
for line_to_clean in new_orders.mapped("order_line").filtered(lambda x: False in x.mapped("tax_id.active")):
line_to_clean.tax_id = [Command.unlink(x.id) for x in line_to_clean.tax_id.filtered(lambda x: not x.active)]
return new_orders

@api.depends("force_invoiced_status")
Expand Down