[FIX] stock_voucher: prevent division by zero in declared value calculation #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation X-original-commit: cecb187
Collaborator
|
|
Contributor
Author
|
@ced-adhoc @jcadhoc cherrypicking of pull request #807 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
Author
|
@ced-adhoc @jcadhoc this forward port of #807 is awaiting action (not merged or closed). |
3 similar comments
Contributor
Author
|
@ced-adhoc @jcadhoc this forward port of #807 is awaiting action (not merged or closed). |
Contributor
Author
|
@ced-adhoc @jcadhoc this forward port of #807 is awaiting action (not merged or closed). |
Contributor
Author
|
@ced-adhoc @jcadhoc this forward port of #807 is awaiting action (not merged or closed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When product_id differs between sale order line and stock move, the move
is treated as a potential BOM component. If no valid BOM is found or no
components match, the picking_avg and done_avg lists remain empty,
causing a ZeroDivisionError when calculating averages.
Add validation to ensure lists are not empty before division.
Forward-Port-Of: #807