Skip to content

Conversation

@jjscarafia
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 20:26
@roboadhoc
Copy link
Collaborator

Pull request status dashboard

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR realiza la migración de los módulos de batch picking de Odoo 18 a Odoo 19, eliminando completamente el módulo stock_batch_picking_voucher y simplificando el módulo stock_batch_picking_ux al remover la funcionalidad relacionada con vouchers/remitos.

  • Migración del método unlink() a @api.ondelete() en stock_ux siguiendo el patrón de Odoo 19
  • Eliminación completa del módulo stock_batch_picking_voucher y todas sus funcionalidades
  • Simplificación de stock_batch_picking_ux removiendo campos y lógica relacionada con vouchers, paquetes y validaciones asociadas

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
stock_ux/models/stock_picking.py Migración correcta del método unlink() a decorador @api.ondelete() para Odoo 19
stock_batch_picking_voucher/* Eliminación completa del módulo (manifest, modelos, vistas, reportes, controladores, traducciones)
stock_batch_picking_ux/manifest.py Actualización de versión a 19.0.1.0.0, eliminación de dependencia stock_voucher y archivo de vistas, cambio a installable: True
stock_batch_picking_ux/models/init.py Eliminación de imports de módulos removidos (stock_picking, stock_move_line, stock_picking_voucher)
stock_batch_picking_ux/models/stock_batch_picking.py Eliminación de campos relacionados con vouchers y paquetes; adición de lógica para prevenir borrado físico de pickings; limpieza de validaciones obsoletas
stock_batch_picking_ux/models/stock_picking.py Archivo completamente eliminado
stock_batch_picking_ux/models/stock_move_line.py Archivo completamente eliminado
stock_batch_picking_ux/models/stock_picking_voucher.py Archivo completamente eliminado
stock_batch_picking_ux/views/stock_batch_picking_views.xml Simplificación de la vista: eliminación de campos de voucher y reorganización de campos de partner
stock_batch_picking_ux/views/stock_picking_views.xml Vista completamente eliminada

Comment on lines +21 to +26
# restrict_number_package = fields.Boolean(
# compute="_compute_picking_type_data",
# )
# number_of_packages = fields.Integer(
# copy=False,
# )
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se están eliminando campos almacenados (voucher_number y number_of_packages) del modelo stock.picking.batch sin proporcionar un script de migración.

Según las guías de migración, cuando se eliminan campos almacenados se debe crear un script de migración en migrations/19.0.1.0.0/pre-migration.py para eliminar las columnas de la base de datos de forma limpia:

def migrate(cr, version):
    # Eliminar campos obsoletos
    cr.execute("ALTER TABLE stock_picking_batch DROP COLUMN IF EXISTS voucher_number")
    cr.execute("ALTER TABLE stock_picking_batch DROP COLUMN IF EXISTS number_of_packages")
    cr.execute("ALTER TABLE stock_picking_batch DROP COLUMN IF EXISTS voucher_required")
    cr.execute("ALTER TABLE stock_picking_batch DROP COLUMN IF EXISTS restrict_number_package")

Esto evita warnings y problemas durante la actualización del módulo.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +108 to 112
# if rec.restrict_number_package and not rec.number_of_packages > 0:
# raise UserError(_("The number of packages can not be 0"))
# if rec.number_of_packages:
# rec.picking_ids.write({"number_of_packages": rec.number_of_packages})

Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment appears to contain commented-out code.

Suggested change
# if rec.restrict_number_package and not rec.number_of_packages > 0:
# raise UserError(_("The number of packages can not be 0"))
# if rec.number_of_packages:
# rec.picking_ids.write({"number_of_packages": rec.number_of_packages})
# Si se requiere la restricción de número de paquetes, validar aquí.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants