[FIX] stock_currency_valuation: Fix on posting moves with different company_id by feg-adhoc · Pull Request #872 · ingadhoc/stock

feg-adhoc · 2026-02-10T18:45:15Z

…

…ompany_id

roboadhoc · 2026-02-10T18:45:18Z

Copilot

Pull request overview

Este PR corrige un bug en el módulo stock_currency_valuation que ocurría al intentar publicar movimientos contables (_post) que pertenecían a diferentes compañías. El problema original era que el método aplicaba el contexto con la cuenta de intercambio de moneda de self.company_id, asumiendo que todos los movimientos pertenecían a la misma compañía.

Changes:

Refactorización del método _post para agrupar movimientos por compañía y procesarlos individualmente con el contexto correcto
Eliminación de imports no utilizados (collections.defaultdict, fields, float_compare, float_is_zero)
Mejora en el manejo de escenarios multi-compañía aplicando el contexto específico de cada compañía a sus movimientos correspondientes

Copilot · 2026-02-10T18:49:01Z

stock_currency_valuation/models/account_move.py

+            # Llamar al super con el contexto específico de cada compañía
+            posted_moves |= super(AccountMove, moves.with_context(
+                bypass_update_product_price=True,
+                force_input_acount=income_currency_exchange_account_id,


Hay un error de ortografía en el nombre del parámetro del contexto: 'force_input_acount' debería ser 'force_input_account' (falta la 'c' en 'account').

Suggested change

force_input_acount=income_currency_exchange_account_id,

force_input_account=income_currency_exchange_account_id,

Copilot · 2026-02-10T18:49:01Z

stock_currency_valuation/models/account_move.py

+                force_input_acount=income_currency_exchange_account_id,
+                default_bypass_currency_valuation=True)
+            )._post(soft=soft)
+


Espacios en blanco al final de la línea. Aunque esto no afecta la funcionalidad, es una convención de estilo limpio eliminar los espacios finales innecesarios.

Suggested change

Copilot · 2026-02-10T18:49:01Z

stock_currency_valuation/models/account_move.py

    def _post(self, soft=True):
-        income_currency_exchange_account_id = self.company_id.income_currency_exchange_account_id.id
-        return super(AccountMove, self.with_context(
-            bypass_update_product_price=True,
-            force_input_acount=income_currency_exchange_account_id,
-            default_bypass_currency_valuation=True)
-        )._post(soft=soft)
+        # Agrupar los movimientos por compañía y procesar cada grupo con su contexto
+        posted_moves = self.env['account.move']
+        for company in self.mapped('company_id'):
+            moves = self.filtered(lambda m: m.company_id == company)
+            income_currency_exchange_account_id = company.income_currency_exchange_account_id.id
+            # Llamar al super con el contexto específico de cada compañía
+            posted_moves |= super(AccountMove, moves.with_context(
+                bypass_update_product_price=True,
+                force_input_acount=income_currency_exchange_account_id,
+                default_bypass_currency_valuation=True)
+            )._post(soft=soft)
+
+        return posted_moves


Se ha modificado el comportamiento de un método del modelo (cambio en la lógica de _post) pero no se ha incrementado la versión en manifest.py. Según las convenciones del proyecto, cuando hay cambios estructurales o de lógica en modelos, se debe incrementar la versión (actualmente en 16.0.2.3.0).

Copilot · 2026-02-10T18:49:02Z

stock_currency_valuation/models/account_move.py

+            income_currency_exchange_account_id = company.income_currency_exchange_account_id.id
+            # Llamar al super con el contexto específico de cada compañía
+            posted_moves |= super(AccountMove, moves.with_context(
+                bypass_update_product_price=True,
+                force_input_acount=income_currency_exchange_account_id,
+                default_bypass_currency_valuation=True)
+            )._post(soft=soft)
+


Riesgo potencial: acceder a .id en company.income_currency_exchange_account_id.id puede fallar si income_currency_exchange_account_id no está configurado (es False). Aunque en Odoo los campos Many2one vacíos retornan False y no un recordset vacío, y False.id lanzaría AttributeError, sería más seguro usar company.income_currency_exchange_account_id.id if company.income_currency_exchange_account_id else False o simplemente pasar el objeto completo al contexto y dejar que Odoo maneje la conversión.

Suggested change

income_currency_exchange_account_id = company.income_currency_exchange_account_id.id

# Llamar al super con el contexto específico de cada compañía

posted_moves |= super(AccountMove, moves.with_context(

bypass_update_product_price=True,

force_input_acount=income_currency_exchange_account_id,

default_bypass_currency_valuation=True)

)._post(soft=soft)

account = company.income_currency_exchange_account_id

income_currency_exchange_account_id = account.id if account else False

# Llamar al super con el contexto específico de cada compañía

posted_moves |= super(AccountMove, moves.with_context(

bypass_update_product_price=True,

force_input_acount=income_currency_exchange_account_id,

default_bypass_currency_valuation=True)

)._post(soft=soft)

maq-adhoc · 2026-02-13T13:52:04Z

@roboadhoc r+ nobumped

roboadhoc · 2026-02-13T13:52:06Z

@maq-adhoc unknown command 'nobumped'.

For your own safety I've ignored everything in your entire comment.

Currently available commands:

command
`help`	displays this help
`r(eview)+`	approves the PR, if it's a forwardport also approves all non-detached parents
`r(eview)=<number>`	only approves the specified parents
`fw=no`	does not forward-port this PR
`fw=default`	forward-ports this PR normally
`fw=skipci`	does not wait for a forward-port's statuses to succeed before creating the next one
`fw=skipmerge`	does not wait for the source to be merged before creating forward ports
`up to <branch>`	only ports this PR forward to the specified branch (included)
`merge`	integrate the PR with a simple merge commit, using the PR description as message
`rebase-merge`	rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
`rebase-ff`	rebases the PR on top of the target branch, then fast-forwards
`squash`	squashes the PR as a single commit on the target branch, using the PR description as message
`delegate+`	grants approval rights to the PR author
`delegate=<...>`	grants approval rights on this PR to the specified github users
`nice`	only stages the PR if there's room in the batch after `default` PRs
`default`	stages the PR normally
`priority`	tries to stage this PR first, then adds `default` PRs if the staging has room
`alone`	stages this PR only with other PRs of the same priority
`cancel=staging`	automatically cancels the current staging when this PR becomes ready
`override=<...>`	marks overridable statuses as successful
`check`	fetches or refreshes PR metadata, resets mergebot state

Note: this help text is dynamic and will change with the state of the PR.

rov-adhoc · 2026-02-13T15:29:45Z

@roboadhoc r+ nobump

…ompany_id closes #872 Signed-off-by: rov-adhoc <[email protected]>

[FIX] stock_currency_valuation: Fix on posting moves with different c…

2b72193

…ompany_id

Copilot AI review requested due to automatic review settings February 10, 2026 18:45

Copilot started reviewing on behalf of feg-adhoc February 10, 2026 18:46 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

roboadhoc pushed a commit that referenced this pull request Feb 13, 2026

[FIX] stock_currency_valuation: Fix on posting moves with different c…

d39226f

…ompany_id closes #872 Signed-off-by: rov-adhoc <[email protected]>

fw-bot-adhoc mentioned this pull request Feb 13, 2026

[FIX] stock_currency_valuation: Fix on posting moves with different company_id #874

Open

roboadhoc deployed to merge February 13, 2026 15:30 Active

roboadhoc closed this Feb 13, 2026

roboadhoc deleted the 16.0-h-110422-feg branch February 13, 2026 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] stock_currency_valuation: Fix on posting moves with different company_id#872

[FIX] stock_currency_valuation: Fix on posting moves with different company_id#872
feg-adhoc wants to merge 1 commit intoingadhoc:16.0from
adhoc-dev:16.0-h-110422-feg

feg-adhoc commented Feb 10, 2026

Uh oh!

roboadhoc commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

maq-adhoc commented Feb 13, 2026

Uh oh!

roboadhoc commented Feb 13, 2026

Uh oh!

rov-adhoc commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

	force_input_acount=income_currency_exchange_account_id,
	force_input_account=income_currency_exchange_account_id,

Conversation

feg-adhoc commented Feb 10, 2026

Uh oh!

roboadhoc commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

maq-adhoc commented Feb 13, 2026

Uh oh!

roboadhoc commented Feb 13, 2026

Uh oh!

rov-adhoc commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments