fix: query for previous host block instead of current host block #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
approved these changes
Jun 17, 2025
Evalir
approved these changes
Jun 18, 2025
prestwich
changed the base branch from
prestwich/span-closure
to
graphite-base/114
prestwich
force-pushed
the
dylan/fix_query_for_previous_host_block_instead_of_current_host_block
branch
from
5ecee6f to
184b9fb
Compare
prestwich
changed the base branch from
graphite-base/114
to
prestwich/span-closure
prestwich
changed the base branch from
prestwich/span-closure
to
graphite-base/114
|
this was folded into #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: query for previous host block instead of current host block
When querying for the host block during host transaction preparation, the builder calculates the host block number from the rollup block number.
This result needs to be reduced by 1, otherwise the block being queried is the host block currently being built which, of course, can't be queried.
Fixes ENG-1132.