fix: make block query cutoff properly configurable #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
requested changes
Nov 21, 2025
src/config.rs
Outdated
|
|
||
| /// Number of seconds before the end of the slot to stop querying for new blocks | ||
| #[from_env( | ||
| var = "BLOCK_QUERY_CUTOFF_SECS", |
Member
There was a problem hiding this comment.
let's change to BLOCK_QUERY_CUTOFF
src/config.rs
Outdated
| desc = "Number of seconds before the end of the slot to stop querying for new blocks", | ||
| default = 2 | ||
| )] | ||
| pub block_query_cutoff_secs: u64, |
Member
There was a problem hiding this comment.
ditto, for consistency with other services
Evalir
requested changes
Nov 21, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
Actually, disregard the other review. This should be called BLOCK_QUERY_CUTOFF_BUFFER
rswanson
reviewed
Nov 21, 2025
| #[from_env( | ||
| var = "BLOCK_QUERY_CUTOFF_BUFFER", | ||
| desc = "Number of seconds before the end of the slot to stop querying for new blocks", | ||
| default = 2 |
prestwich
requested changes
Nov 21, 2025
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
seconds is not enough resolution. needs to be milliseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: make block query cutoff properly configurable
At some point in the past, the block query cutoff configuration value was removed and a hard-coded value was added in.
This PR adds the block query cutoff back into the config and uses the config value in the
calculate_deadline function.Builder example environment documentation needs to be updated to reflect this change.