Skip to content

Add async log warning and error convenience helpers #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add async log warning and error convenience helpers #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Logging/SLLogger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,21 @@ void SLLog(NSString *format, ...) NS_FORMAT_FUNCTION(1,2);
*/
void SLLogAsync(NSString *format, ...) NS_FORMAT_FUNCTION(1, 2);

/**
Asynchronously logs a warning message to the testing environment.

@param format A format string (in the manner of `-[NSString stringWithFormat:]`).
@param ... (Optional) A comma-separated list of arguments to substitute into `format`.
*/
void SLLogWarningAsync(NSString *format, ...) NS_FORMAT_FUNCTION(1, 2);

/**
Asynchronously logs an error message to the testing environment.

@param format A format string (in the manner of `-[NSString stringWithFormat:]`).
@param ... (Optional) A comma-separated list of arguments to substitute into `format`.
*/
void SLLogErrorAsync(NSString *format, ...) NS_FORMAT_FUNCTION(1, 2);

/**
The shared `SLLogger` used by Subliminal to log test progress. It may also be
Expand Down
22 changes: 22 additions & 0 deletions Logging/SLLogger.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,28 @@ void SLLogAsync(NSString *format, ...) {
});
}

void SLLogWarningAsync(NSString *format, ...) {
va_list args;
va_start(args, format);
NSString *message = [[NSString alloc] initWithFormat:format arguments:args];
va_end(args);

dispatch_async([[SLLogger sharedLogger] loggingQueue], ^{
[[SLLogger sharedLogger] logWarning:message];
});
}

void SLLogErrorAsync(NSString *format, ...) {
va_list args;
va_start(args, format);
NSString *message = [[NSString alloc] initWithFormat:format arguments:args];
va_end(args);

dispatch_async([[SLLogger sharedLogger] loggingQueue], ^{
[[SLLogger sharedLogger] logError:message];
});
}

@implementation SLLogger {
dispatch_queue_t _loggingQueue;
}
Expand Down