Add compute instance scenario support to test server #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enhances the test server to support compute instance and template mocking using YAML-based test data, making it easier to test the CLI against realistic compute instance scenarios. Changes: - Add ComputeInstanceScenario infrastructure to load test data from YAML - Add compute-instances-and-templates.yaml with sample instances/templates - Update test server to use scenario data for compute instance operations - Return NotFound errors for non-existent resources instead of dummy data - Add CEL filter support for deletion_timestamp queries in List operations Example usage with test server: ``` $ ./fulfillment-cli get computeinstances ID NAME TEMPLATE STATE EXTERNAL IP ci-mock-12345 mock-instance small-instance READY 192.168.1.100 ci-mock-67890 test-instance large-instance PROGRESSING 192.168.1.101 $ ./fulfillment-cli describe computeinstance ci-mock-12345 ID: ci-mock-12345 Template: tpl-small-001 State: READY $ ./fulfillment-cli describe computeinstance nonexistent Error: failed to describe compute instance: rpc error: code = NotFound desc = compute instance "nonexistent" not found $ ./fulfillment-cli get computeinstancetemplates ID NAME TITLE tpl-small-001 small-instance Small Instance Template tpl-large-001 large-instance Large Instance Template $ ./fulfillment-cli create computeinstance --template tpl-large-001 --name new-test-instance Created compute instance 'ci-mock-12345'. ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This change adds proper automated testing for compute instance operations and removes the manual test server implementation that was added in the previous commit. Changes: - Add MockComputeInstancesServer for automated testing - Add MockComputeInstanceTemplatesServer for automated testing - Add e2e test that verifies create, list, get, and delete operations - Remove compute instance handling from test-server - Remove compute-instances-and-templates.yaml (not needed) The e2e test validates the complete CRUD lifecycle: 1. Lists templates to get a valid template ID 2. Lists existing instances (initial count) 3. Creates a new compute instance 4. Verifies the instance appears in list (count increased) 5. Gets the created instance by ID 6. Deletes the instance 7. Verifies the instance was deleted (count back to initial) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds automated e2e tests for compute instance operations.
Changes
Testing
The e2e test validates the complete CRUD lifecycle:
🤖 Generated with Claude Code