Allow strings as response without a wrapping tag. - #241
Open
jesusabarca wants to merge 17 commits into
Open
Conversation
… the minitest plugin.
Bumps up version of rails from 5.0.0 to 5.0.3
wrapping them in a <Value></Value> tag.
…onse Adds option for returning single strings in the response
jesusabarca
commented
Aug 30, 2017
|
|
||
| appraise "rails-5.0.0" do | ||
| gem "rails", "5.0.0" | ||
| appraise "rails-5.0.3" do |
Contributor
Author
There was a problem hiding this comment.
Bumps up version of rails from 5.0.0 to 5.0.3 to include a bug fix in the minitest plugin rails/rails#29022. This only prevents the test suit from crashing. This PR will fix this #238, so it's just a temporal fix.
instead of 5.0.0
Option to change the service name
adds custome tags
Return default response as Response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#240
The simplest way I could come up with that didn't required a major refactor, was to pass a
wrap_response: falseoption to therendermethod in the controller:What do you guys think? :)