Fix string will be frozen in the future warning (Issue #280) - #281
Open
KarlHeitmann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #280 , if you use ruby 3.4 and you set the ENV var
RUBYOPT="-W:deprecated"you will get a warning, because soap_action is a string literal that is mutating by thesoap_action.force_encoding('UTF-8')method call.the
soap_actionwas in lib/wash_out/routes:60.soap_action.keys.firstwill return aSymbolinstance, in Ruby 4Symbol.to_swill return a frozen string literal, so the warning is telling us when this string will become a frozen string literal in Ruby 4, this line will break.By wrapping line 60 with
String.new(...), it will take that frozen string literal and will convert it into a mutable string literal. The code will be safe.