refactor(web-extension)!: make KeyAgentFactory methods async #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemyslaw-wlodek
previously approved these changes
Jan 21, 2025
Contributor
przemyslaw-wlodek
left a comment
przemyslaw-wlodek
left a comment
There was a problem hiding this comment.
🚀 LGTM. Thank you!
Bip32Ed25519 was refactored to synchronous methods by hoisting sodium await to top level in #1558, which makes it difficult to use SigningCoordinator without top level await
mkazlauskas
dismissed stale reviews from przemyslaw-wlodek and AngelCastilloB
via
069b2b5
mkazlauskas
force-pushed
the
refactor/async-key-agent-factory
branch
from
a9a8ab8 to
069b2b5
Compare
AngelCastilloB
approved these changes
Jan 21, 2025
przemyslaw-wlodek
approved these changes
Jan 21, 2025
mirceahasegan
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Bip32Ed25519 was refactored to synchronous methods by hoisting sodium await to top level in #1558, which makes it difficult to use SigningCoordinator without top level await
Proposed Solution
Important Changes Introduced