- 
                Notifications
    
You must be signed in to change notification settings  - Fork 63
 
feat: sign multi-sig transaction with hw wallet #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
 | 
    
914260f    to
    bea8bc1      
    Compare
  
    bea8bc1    to
    9746701      
    Compare
  
    9746701    to
    e3d3503      
    Compare
  
    e3d3503    to
    fd4b610      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @greatertomi I made a few change request, main point is, this change should allow hardware wallets to sign transactions with native scripts, which will work for shared wallet, but also for dApps, rather than making this specific to sharedWallets
fd4b610    to
    338f923      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @greatertomi ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @greatertomi. Just a minor change req
76d973c    to
    b418fff      
    Compare
  
    b418fff    to
    8f471b4      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval is for resolution of #1604 (comment).
8f471b4    to
    b658c82      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
Context
This PR introduces support for signing multi-sig transactions using both Ledger and Trezor hardware wallets
Proposed Solution
Important Changes Introduced