-
Notifications
You must be signed in to change notification settings - Fork 0
feat(rust): Replace base64-url with base64
#234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Test Report | |
stevenj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a necessary change. Not prioritized.
This change would then require a release and bumping other crates.
Not approved.
no30bit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be opinionated, but I'd re-export URL_SAFE_NO_PAD from catalyst-types as DEFAULT_BASE64 to eliminate the choice among alphabets in every instance of the decoding/encoding logic.
I agree, using this raw is a bit ugly. So if we re-export it, we can make it look nicer, and instead of doing this: We could still say use |
Description
Replace
base64-urlwhich is simply just a wrapper overbase64crate https://github.com/magiclen/base64-url/blob/7bcd29e6b1c21bc4b2592d40d9b493ab4ff3fad4/Cargo.toml#L16.Simplify our dependency tree.