Skip to content

fix(rust/signed-doc): Modify the DocumentRef structure #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 23, 2025

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jun 3, 2025

Description

Modify the DocumentRef structure according to https://input-output-hk.github.io/catalyst-libs/architecture/08_concepts/signed_doc/metadata/#document-reference

Related Issue(s)

#323

Description of Changes

Change the structure of DocumentRef from {id, ver} to DocumentRefs
that store a list of DocumentRef {id, ver, locator}

Breaking Changes

The structure of document ref changed

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Jun 3, 2025
@bkioshn bkioshn added this to Catalyst Jun 3, 2025
@bkioshn bkioshn added the enhancement New feature or request label Jun 3, 2025
@bkioshn bkioshn moved this from New to 🏗 In progress in Catalyst Jun 3, 2025
@bkioshn bkioshn changed the title fix(rust/signed-doc) Modify the DocumentRef structure fix(rust/signed-doc): Modify the DocumentRef structure Jun 3, 2025
@bkioshn bkioshn moved this from 🏗 In progress to 👀 In review in Catalyst Jun 19, 2025
@bkioshn bkioshn added the review me PR is ready for review label Jun 19, 2025
@bkioshn bkioshn marked this pull request as ready for review June 19, 2025 12:24
@bkioshn bkioshn added backend Task could/should be picked up as work on the backend. and removed review me PR is ready for review labels Jun 19, 2025
@bkioshn bkioshn marked this pull request as draft June 19, 2025 12:37
@bkioshn bkioshn added the review me PR is ready for review label Jun 20, 2025
@bkioshn bkioshn marked this pull request as ready for review June 23, 2025 04:10
…#368)

* fix(signed-doc): wip apply new doc ref

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): apply new doc ref and implement validation rule for doc ref

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): revert doc type change

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): remove problem report in encoder

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): metadata decode

Signed-off-by: bkioshn <[email protected]>

* chore(signed-doc): revert change

Signed-off-by: bkioshn <[email protected]>

* test(signed-doc): add docref to decoding test

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): format

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): refactor and improvement

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): refactor

Signed-off-by: bkioshn <[email protected]>

* test(signed-doc): fix content test

Signed-off-by: bkioshn <[email protected]>

* test(signed-doc): fix content test

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
@Mr-Leshiy Mr-Leshiy merged commit 6a1be0b into feat/new-cat-signed-doc Jun 23, 2025
20 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/mod-doc-ref branch June 23, 2025 08:16
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jun 23, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 362/362}$ | ${\color{red}Fail: 0/362}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task could/should be picked up as work on the backend. enhancement New feature or request review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants