-
Notifications
You must be signed in to change notification settings - Fork 0
feat(rust/signed-doc): New implementation of DocType
#356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
* feat(signed-doc): add new type DocType Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): add conversion policy Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): doc type Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): doc type error Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): seperate test Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): format Signed-off-by: bkioshn <[email protected]> --------- Signed-off-by: bkioshn <[email protected]>
…gned Documents (#349) * wip * wip * fix fmt * fix spelling * fix clippy
* feat(signed-doc): add new type DocType Signed-off-by: bkioshn <[email protected]> * wip: apply doctype Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): add more function to DocType Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): map old doctype to new doctype Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): add eq to uuidv4 Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): fix validator Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): minor fixes Signed-off-by: bkioshn <[email protected]> * fix(catalyst-types): add hash to uuidv4 Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): decoding test Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): doctype Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): minor fixes Signed-off-by: bkioshn <[email protected]> * chore(sign-doc): fix comment Signed-off-by: bkioshn <[email protected]> * fix(catalyst-types): add fromstr to uuidv4 and 7 Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): restructure doctypes Signed-off-by: bkioshn <[email protected]> * fix(signed-doc): test Signed-off-by: bkioshn <[email protected]> * Update rust/signed_doc/tests/proposal.rs * Update rust/signed_doc/tests/comment.rs * Update rust/signed_doc/tests/submission.rs --------- Signed-off-by: bkioshn <[email protected]> Co-authored-by: Alex Pozhylenkov <[email protected]>
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine.
But do not merge to main until its tested with the FE.
Also confirm with QA before merging this and the matching FE to see if its OK to land before the next dry run. Which is my preference.
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Description
New implementation of
DocType
Commit pick from #338
Changes
Additional modifications were introduced beyond what was originally approved.
rust/signed_doc/src/validator/mod.rs
-> Rule should be backward compatible. Confirm with frontend that single UUIDv4 is now changing to list of UUIDv4 eg.7808d2ba-d511-40af-84e8-c0d1625fdfdc
to[7808d2ba-d511-40af-84e8-c0d1625fdfdc]
doc_types/mod
because the old one is confusingRelated Issue(s)
type
field #328Breaking Changes
Must not be any breaking change, should be compatible with the old implementation
Please confirm the following checks