Skip to content

feat(rust/signed-doc): New implementation of DocType #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jun 5, 2025

Description

New implementation of DocType

Commit pick from #338

Changes

Additional modifications were introduced beyond what was originally approved.

  • rust/signed_doc/src/validator/mod.rs -> Rule should be backward compatible. Confirm with frontend that single UUIDv4 is now changing to list of UUIDv4 eg. 7808d2ba-d511-40af-84e8-c0d1625fdfdc to [7808d2ba-d511-40af-84e8-c0d1625fdfdc]
  • Rename + Restructure doc_types/mod because the old one is confusing

Related Issue(s)

Breaking Changes

Must not be any breaking change, should be compatible with the old implementation

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

bkioshn and others added 7 commits May 19, 2025 20:26
Signed-off-by: bkioshn <[email protected]>
* feat(signed-doc): add new type DocType

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add conversion policy

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): doc type

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): doc type error

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): seperate test

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): format

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
…gned Documents (#349)

* wip

* wip

* fix fmt

* fix spelling

* fix clippy
* feat(signed-doc): add new type DocType

Signed-off-by: bkioshn <[email protected]>

* wip: apply doctype

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add more function to DocType

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): map old doctype to new doctype

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add eq to uuidv4

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): fix validator

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): minor fixes

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): add hash to uuidv4

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): decoding test

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): doctype

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): minor fixes

Signed-off-by: bkioshn <[email protected]>

* chore(sign-doc): fix comment

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): add fromstr to uuidv4 and 7

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): restructure doctypes

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): test

Signed-off-by: bkioshn <[email protected]>

* Update rust/signed_doc/tests/proposal.rs

* Update rust/signed_doc/tests/comment.rs

* Update rust/signed_doc/tests/submission.rs

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Alex Pozhylenkov <[email protected]>
@bkioshn bkioshn marked this pull request as ready for review June 5, 2025 03:48
@bkioshn bkioshn self-assigned this Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Test Report | ${\color{lightgreen}Pass: 336/336}$ | ${\color{red}Fail: 0/336}$ |

@stevenj stevenj added review me PR is ready for review do not merge yet PR is not ready to merge yet labels Jun 5, 2025
@stevenj stevenj added this to Catalyst Jun 5, 2025
@stevenj stevenj moved this from New to 👀 In review in Catalyst Jun 5, 2025
stevenj
stevenj previously approved these changes Jun 5, 2025
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.
But do not merge to main until its tested with the FE.
Also confirm with QA before merging this and the matching FE to see if its OK to land before the next dry run. Which is my preference.

@bkioshn bkioshn marked this pull request as ready for review June 10, 2025 09:53
@bkioshn bkioshn removed the do not merge yet PR is not ready to merge yet label Jun 11, 2025
@bkioshn bkioshn added enhancement New feature or request backend Task could/should be picked up as work on the backend. labels Jun 11, 2025
stevenj
stevenj previously approved these changes Jun 11, 2025
@bkioshn bkioshn added the do not merge yet PR is not ready to merge yet label Jun 12, 2025
@bkioshn bkioshn dismissed stale reviews from stevenj and stanislav-tkach via 54924f8 June 12, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task could/should be picked up as work on the backend. do not merge yet PR is not ready to merge yet enhancement New feature or request review me PR is ready for review
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

4 participants