Skip to content

feat(rust/signed-doc): signed doc metadata serde refactoring #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

no30bit
Copy link
Contributor

@no30bit no30bit commented Jun 20, 2025

Description

Removes InnerMetdata. Maintains serde::Deserialize impl. Extends Metadata api with from_fields constructor.

Related Issue(s)

Closes #366

Description of Changes

  • Remove InnerMetadata.
  • Implement Serialize for supported_field types.
  • Implement Metadata::from_json – replacing previous impl with InnerMetadata.
  • Add Metadata::from_fields that does the same as Metadata::from_metadata_fields used to do, but accepts a vector of SupportedField.

Breaking Changes

No.

Related Pull Requests

#338

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@no30bit no30bit requested review from Mr-Leshiy, bkioshn and cong-or June 20, 2025 03:40
@no30bit no30bit self-assigned this Jun 20, 2025
@no30bit no30bit added this to Catalyst Jun 20, 2025
@no30bit no30bit added enhancement New feature or request review me PR is ready for review backend Task could/should be picked up as work on the backend. labels Jun 20, 2025
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Test Report | ${\color{lightgreen}Pass: 351/351}$ | ${\color{red}Fail: 0/351}$ |

@github-project-automation github-project-automation bot moved this from New to 🔖 Ready in Catalyst Jun 20, 2025
@no30bit no30bit requested a review from Mr-Leshiy June 20, 2025 12:23
@no30bit no30bit moved this from 🔖 Ready to 👀 In review in Catalyst Jun 20, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 8d6b5c9 into feat/new-cat-signed-doc Jun 20, 2025
42 of 45 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/new-cat-signed-doc-metadata-serde branch June 20, 2025 12:31
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task could/should be picked up as work on the backend. enhancement New feature or request review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants