-
Notifications
You must be signed in to change notification settings - Fork 0
feat(rust/signed-doc): signed doc metadata serde refactoring #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mr-Leshiy
merged 9 commits into
feat/new-cat-signed-doc
from
feat/new-cat-signed-doc-metadata-serde
Jun 20, 2025
Merged
feat(rust/signed-doc): signed doc metadata serde refactoring #372
Mr-Leshiy
merged 9 commits into
feat/new-cat-signed-doc
from
feat/new-cat-signed-doc-metadata-serde
Jun 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Test Report | |
Mr-Leshiy
requested changes
Jun 20, 2025
Mr-Leshiy
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Task could/should be picked up as work on the backend.
enhancement
New feature or request
review me
PR is ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
InnerMetdata
. Maintainsserde::Deserialize
impl. ExtendsMetadata
api withfrom_fields
constructor.Related Issue(s)
Closes #366
Description of Changes
InnerMetadata
.Serialize
forsupported_field
types.Metadata::from_json
– replacing previous impl withInnerMetadata
.Metadata::from_fields
that does the same asMetadata::from_metadata_fields
used to do, but accepts a vector ofSupportedField
.Breaking Changes
No.
Related Pull Requests
#338
Please confirm the following checks