fix(cat-gateway): Fix cardano/assets endpoint.
#2109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
requested review from
stevenj,
cong-or,
saibatizoku,
bkioshn and
stanislav-tkach
as code owners
|
✅ Test Report | |
cong-or
reviewed
Mar 27, 2025
cong-or
reviewed
Mar 27, 2025
catalyst-gateway/bin/src/service/api/cardano/staking/assets_get.rs
Outdated
Show resolved
Hide resolved
cong-or
approved these changes
Mar 28, 2025
stevenj
requested changes
Mar 31, 2025
There was a problem hiding this comment.
Remove the unnecessary type refactoring.
Don't call anything "Native Tokens" its not a valid reference to an onchain value. They are Assetts according to the spec, and we should align with its language to reduce confusion.
Don't serialize getting the TXI set, and updating the TXO data with the spent information as its bad from a performance perspective and un-required.from a correctness perspective.
Reading the TXI's and updaing TXO's is logically two distinct operations and should be coded as two distinct operations.
catalyst-gateway/bin/src/db/index/queries/staked_ada/get_assets_by_stake_address.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/db/index/queries/staked_ada/get_txo_by_stake_address.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/service/api/cardano/staking/assets_get.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/service/api/cardano/staking/assets_get.rs
Outdated
Show resolved
Hide resolved
stevenj
requested changes
Apr 1, 2025
catalyst-gateway/bin/src/service/api/cardano/staking/assets_get.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/service/api/cardano/staking/assets_get.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/service/common/objects/cardano/stake_info.rs
Outdated
Show resolved
Hide resolved
…info.rs Co-authored-by: Steven Johnson <[email protected]>
Mr-Leshiy
added a commit
that referenced
this pull request
Apr 17, 2025
* fix(cat-gateway): Fixing indexing issues and chain follower synchronisation (#2100) * update cardano sync code * wip * wip * wip * wip * wip * wip * wip * wip * wip * fix fmt * change schema version * wip * wip * wip * wip * fix(cat-gateway): Fix `cardano/assets` endpoint. (#2109) * fix assets endpoint * wip * wip * wip * wip * wip * fix spelling * Update catalyst-gateway/bin/src/service/common/objects/cardano/stake_info.rs Co-authored-by: Steven Johnson <[email protected]> * wip --------- Co-authored-by: Steven Johnson <[email protected]> * fix(cat-gateway): Use persistent state in volatile asset calculation (#2160) * fix(cat-gateway): separate futures * fix(cat-gateway): calculate volatile assets * wip * remove unused code --------- Co-authored-by: Mr-Leshiy <[email protected]> * fix(cat-gateway): Correct Service Health logic (#1974) * wip(rust/signed_doc): add atomic variables for live check, update endpoint and middleware * wip(rust/signed_doc): reset live counter * fix(cat-gateway): typo * fix(cat-gateway): use timestamp for LIVE_COUNTER, update logic * fix(cat-gateway): refactor code into health utilities * fix(cat-gateway): fix panic catcher to disable live service flag * fix(cat-gateway): remove unused atomic-counter crate * fix(cat-gateway): refactor health::live utilities into proper module * fix(cat-gateway): restore live counter logic, set env var for threshold * fix(cat-gateway): code format * fix(cat-gateway): return service unavailable with proper error * fix(cat-gateway): refactor health::start utilities into proper module * feat(cat-gateway): add service::utilities::health::ready module * wip(rust/signed_doc): add atomic variables for live check, update endpoint and middleware * wip(rust/signed_doc): reset live counter * fix(cat-gateway): typo * fix(cat-gateway): use timestamp for LIVE_COUNTER, update logic * fix(cat-gateway): refactor code into health utilities * fix(cat-gateway): fix panic catcher to disable live service flag * fix(cat-gateway): remove unused atomic-counter crate * fix(cat-gateway): refactor health::live utilities into proper module * fix(cat-gateway): restore live counter logic, set env var for threshold * fix(cat-gateway): code format * fix(cat-gateway): return service unavailable with proper error * fix(cat-gateway): add atomic vars to health::started to keep track and set state * fix(cat-gateway): add atomic var to health::started to keep track of chain follower * fix(cat-gateway): implement logic for health::started flags * fix(cat-gateway): add middleware to check DB connections * fix(cat-gateway): attempt DB reconnect if health/ready check fails * fix(cat-gateway): implement logic for health::ready endpoint * fix(cat-gateway): handle DB errors at endpoints * chore(cat-gateway): fix doc comments * fix(cat-gateway): add suggested fixes * fix(cat-gateway): simplify boolean logic, correctly set flag when follower first syncs * fix(cat-gateway): add suggested fix * chore(docs): fix doc comment * fix(cat-gateway): update doc comments for health endpoints * fix(cat-gateway): add suggested fix to doc comments * wip * fix(cat-gateway): set index db liveness after waiting for it to be ready --------- Co-authored-by: Alex Pozhylenkov <[email protected]> Co-authored-by: Steven Johnson <[email protected]> * feat(cat-gateway): `cardano/assets` integration test (#2139) * add assets test * wip * fix * wip * wip * fix(cat-gateway): Fix test_assets.py (#2300) * fix assets test * wip * fix * try * wip * wip * wip * fix * wip * increase timeout for `schemathesis` --------- Co-authored-by: Steven Johnson <[email protected]> Co-authored-by: Joaquín Rosales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #1986
cardano/assetsendpoint