-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): build time env and runtime config #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
damian-molinski
wants to merge
48
commits into
main
Choose a base branch
from
feat/build_time_env_and_runtime_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Test Report | |
minikin
reviewed
Apr 3, 2025
…nput-output-hk/catalyst-voices into feat/build_time_env_and_runtime_config
Merged
8 tasks
dtscalac
reviewed
May 2, 2025
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/config/app_config.dart
Outdated
Show resolved
Hide resolved
dtscalac
reviewed
May 2, 2025
.../packages/internal/catalyst_voices_repositories/lib/src/dto/config/remote_sentry_config.dart
Outdated
Show resolved
Hide resolved
dtscalac
reviewed
May 2, 2025
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/config/app_config.dart
Outdated
Show resolved
Hide resolved
dtscalac
previously approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 tasks
* feat: extend blockchain config with slot number * test: config repository test * chore: update frontend config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dart
Pull requests that update Dart code
do not merge yet
PR is not ready to be merged yet
F14
review me
PR is ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows frontend environment to be configured in build-time. It leads other configuration to be fetched in run-time.
Related Issue(s)
Refers to #178
Part of #2120
Closes #2121
Closes #1328
Closes #1348
Closes #2511
Description of Changes
You can set
--dart-define=ENV_NAME
/--flavor
or non:Notes
dev|preprod|prod|relative
Relative env type.
This env is ment to be used when building app for deployment. Doing it this way allows us to have single build which can be deployed anywhere together with gateway and get config this way.
Using dart-define
Use this method if you want to point always to
main.dart
and just changedart-define
. Useful when building an app using cli tools or from IDEUsing flavor
Works the same as dart-define just lower priority.
Using entry point
Probably preferred way in development setting. If you point to
main_prod.dart|main_preprod.dart|main_dev.dart|
it will just use appropriate env and ignore any
--flavour
/--dart-define
varsUsing
main_qa.dart
ormain.dart
will attempt to find env--dart-define
or--flavor
Using bootstrap()
If you're starting app in tests you can override all of above using optional
environment
param.Env source priority
1.
bootstrap()
overrides everything2. "Entry Point" ->
main_prod.dart
|main_dev.dart
etc4.
--dart-define
->ENV_NAME
5.
--flavor
6. Fallback to relative on web and dev in other cases
Please confirm the following checks