Skip to content

test(cat-gateway): Integration test for RBAC endpoint #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 12, 2025

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented May 2, 2025

Description

Add integration test for RBAC GET endpoint

Related Issue(s)

Closes #2384

Description of Changes

  • Testing lookup with stake address and cat id for GET endpoint
  • Refactor the rbac utility
  • Fixing catid description and regex
  • Fix test data

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this May 2, 2025
@bkioshn bkioshn added review me PR is ready for review python Pull requests that update Python code testcase Create a new testcase labels May 5, 2025
@bkioshn bkioshn marked this pull request as ready for review May 5, 2025 05:29
@bkioshn bkioshn marked this pull request as draft May 5, 2025 13:07
@bkioshn bkioshn removed the review me PR is ready for review label May 7, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

Test Report | ${\color{lightgreen}Pass: 723/727}$ | ${\color{red}Fail: 0/727}$ |

@bkioshn bkioshn marked this pull request as ready for review May 9, 2025 06:09
@bkioshn bkioshn moved this from New to 👀 In review in Catalyst May 9, 2025
stevenj
stevenj previously approved these changes May 9, 2025
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stanislav-tkach
stanislav-tkach previously approved these changes May 9, 2025
@bkioshn bkioshn dismissed stale reviews from stevenj and stanislav-tkach via c950ab8 May 12, 2025 03:27
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 75e9b06 into main May 12, 2025
45 checks passed
@Mr-Leshiy Mr-Leshiy deleted the test/rbac-integration-test branch May 12, 2025 07:57
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code testcase Create a new testcase
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RBAC endpoint integration test
4 participants