Skip to content

chore(cat-voices): adding precache video #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 15, 2025
Merged

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented May 7, 2025

Description

This PR adds funtionality to precache videos

Related Issue(s)

N/A

Description of Changes

  • storing pre cache video controllers in GlobalPrecacheAssets

Breaking Changes

N/A

Screenshots

Before:

Screen.Recording.2025-05-07.at.11.23.50.mov

After caching:

Screen.Recording.2025-05-07.at.11.22.12.mov

Related Pull Requests

If applicable, list any related pull requests.

N/A

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx self-assigned this May 7, 2025
@LynxLynxx LynxLynxx added ux/ui UX/UI related issues dart Pull requests that update Dart code labels May 7, 2025
@LynxLynxx LynxLynxx added the review me PR is ready for review label May 7, 2025
@LynxLynxx LynxLynxx moved this from New to 👀 In review in Catalyst May 7, 2025
@LynxLynxx LynxLynxx marked this pull request as ready for review May 7, 2025 09:50
Copy link
Contributor

github-actions bot commented May 7, 2025

Test Report | ${\color{lightgreen}Pass: 725/729}$ | ${\color{red}Fail: 0/729}$ |

@LynxLynxx LynxLynxx requested a review from dtscalac May 8, 2025 11:46
@LynxLynxx LynxLynxx requested a review from damian-molinski May 12, 2025 07:50
@LynxLynxx LynxLynxx requested a review from damian-molinski May 13, 2025 07:42
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LynxLynxx LynxLynxx requested a review from damian-molinski May 14, 2025 11:59
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LynxLynxx LynxLynxx merged commit 9443648 into main May 15, 2025
45 checks passed
@LynxLynxx LynxLynxx deleted the chore/precache-videos branch May 15, 2025 08:10
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants