Skip to content

fix(cat-gateway): Detect Service Outage with Health Endpoints #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2025

Conversation

saibatizoku
Copy link
Contributor

Description

Defines DB connection errors, and updates middleware and endpoints to handle them by setting the relevant DB (Event DB or Index DB) liveness flags.

Closes #2349 .

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku self-assigned this May 7, 2025
@saibatizoku saibatizoku added the bug label May 7, 2025
@saibatizoku saibatizoku added the review me PR is ready for review label May 7, 2025
@saibatizoku saibatizoku moved this from New to 👀 In review in Catalyst May 7, 2025
Copy link

@no30bit no30bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, subject to answering @no30bit questions.

Copy link
Contributor

github-actions bot commented May 9, 2025

Test Report | ${\color{lightgreen}Pass: 725/729}$ | ${\color{red}Fail: 0/729}$ |

@saibatizoku saibatizoku enabled auto-merge (squash) May 13, 2025 13:22
@saibatizoku saibatizoku requested review from no30bit and stevenj May 13, 2025 13:22
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku merged commit 97ee5a9 into main May 13, 2025
38 checks passed
@saibatizoku saibatizoku deleted the fix/service-liveness branch May 13, 2025 13:48
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Heatlh endpoints not detecting outage
5 participants