Skip to content

feat(cat-voices): blockchain slot number config #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

damian-molinski
Copy link
Contributor

Description

Makes blockchain slot number configurable via remote config

Related Issue(s)

Resolves #2511

Description of Changes

Extends blockchain config with slot number

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski self-assigned this May 12, 2025
@damian-molinski damian-molinski added the dart Pull requests that update Dart code label May 12, 2025
@damian-molinski damian-molinski moved this from New to 👀 In review in Catalyst May 12, 2025
@damian-molinski damian-molinski marked this pull request as ready for review May 12, 2025 14:50
@damian-molinski damian-molinski added the review me PR is ready for review label May 12, 2025
Copy link
Contributor

github-actions bot commented May 12, 2025

Test Report | ${\color{lightgreen}Pass: 744/748}$ | ${\color{red}Fail: 0/748}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit afce6ca into feat/build_time_env_and_runtime_config May 13, 2025
64 of 68 checks passed
@damian-molinski damian-molinski deleted the feat/bloc_slot_nr_config_2511 branch May 13, 2025 07:00
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants